Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy Matching #60

Merged
merged 3 commits into from
May 23, 2020
Merged

Fuzzy Matching #60

merged 3 commits into from
May 23, 2020

Conversation

mafdoesthings
Copy link
Collaborator

@mafdoesthings mafdoesthings commented May 23, 2020

Updates to Fuzzy Matching using postgresql pg_trgm extension, allowing us to use nonspecific search terms for gacha characters/summons. This is in response to Issue 45

Ex. 'jeanne' matches 'Jeanne d'Arc (Dark)', 'Jeanne d'Arc (Grand)' etc.

Spark:
sparkfuzzy

Gacha:
gachafuzzy

Updated gacha.js and spark.js, as well as their helper function helpers/decision.js to handle the new operator, and updated datasets.

@jedmund jedmund changed the title Fuzzy Matching - Issue #45 Fuzzy Matching May 23, 2020
@jedmund
Copy link
Owner

jedmund commented May 23, 2020

Can you do these things?

  • In the description, link to the fuzzy matching issue so it gets linked to this PR
  • Add images of the fuzzy matching picker (where the user chooses a result) in the description
  • Add the extension enabling code to startup.pgsql

Updating startup.pgsql to include initializing the fuzzy matching extension, pg_trgm 
(Line 2)
@jedmund jedmund self-requested a review May 23, 2020 11:25
Copy link
Owner

@jedmund jedmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and is super fun to use! It's going to be really neat once we dial it in.

@jedmund jedmund merged commit 18b43de into jedmund:master May 23, 2020
jedmund added a commit that referenced this pull request May 23, 2020
@jedmund jedmund mentioned this pull request May 23, 2020
jedmund added a commit that referenced this pull request May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants