Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Enhance presenter view #327

Closed
4 tasks
jeertmans opened this issue Nov 28, 2023 · 1 comment · Fixed by #482
Closed
4 tasks

[FEATURE] Enhance presenter view #327

jeertmans opened this issue Nov 28, 2023 · 1 comment · Fixed by #482
Labels
enhancement New feature or request present Related to the main "present" feature
Milestone
v6

Comments

@jeertmans
Copy link
Owner

Description

#324 introduced a first presenter view, but it is quite experimental and could be improved:

  • automatically detect two or more screens and display on two separate screens
  • fix --fullscreen CLI option
  • if one screen, what do we do?
  • add button to swap screens?

Other ideas or questions are welcome!

Screenshots

Current view:
Screenshot from 2023-11-28 15-06-13

Additional information

No response
@jeertmans jeertmans added enhancement New feature or request present Related to the main "present" feature labels Nov 28, 2023
@jeertmans jeertmans added this to the v6 milestone Jul 22, 2024
@jeertmans
Copy link
Owner Author

Note: I think it would be great to have an 3-variant enum for hide-info-window: auto, always, and never. A bit like -c/--color[=<WHEN>] with Rust's Clap package.

auto would check if two or more screens are present and, if true, display the content info window on a separate screen.

taibeled added a commit to taibeled/manim-slides that referenced this issue Oct 22, 2024
@taibeled
Adds features from jeertmans#327
fe70bc8 
This changes the ``--hide-info-window-`` command to accept three options: auto, always, and never. Auto will hide the info window if there is only one screen. This also fixes the --full-screen option by moving the info window to monitor 1 and the presentation to monitor 0 by default.
@taibeled taibeled mentioned this issue Oct 22, 2024
Merged
4 tasks
jeertmans added a commit that referenced this issue Dec 11, 2024
@taibeled @pre-commit-ci @jeertmans
feat(cli): smarter info window hiding logic (#482)
05c1a16 
* Adds features from #327

This changes the ``--hide-info-window-`` command to accept three options: auto, always, and never. Auto will hide the info window if there is only one screen. This also fixes the --full-screen option by moving the info window to monitor 1 and the presentation to monitor 0 by default.

* chore(fmt): auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Let Qt decide the screens

* Fix full screen bug

* chore(fmt): auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix(cli): improve logic

* fix

* Revert fixes and clean code

* Update changelog

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request present Related to the main "present" feature
Projects
None yet
Milestone
v6
Development

Successfully merging a pull request may close this issue.

feat(cli): smarter info window hiding logic taibeled/manim-slides
1 participant
@jeertmans