chore(deps): remove subprocess calls to FFMPEG with av
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linked to the progess made in ManimCommunity/manim#3501. The following PR aims at reducing subprocess calls for security and speed reasons. Also, with ManimCommunity/manim#3501 is merged, FFMPEG should not be needed anymore as it is part of `PyAv`.
jeertmans
added
enhancement
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
for more information, see https://pre-commit.ci
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Failure
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 80.22% 80.62% +0.39%
==========================================
Files 21 21
Lines 1790 1801 +11
==========================================
+ Hits 1436 1452 +16
+ Misses 354 349 -5 ☔ View full report in Codecov by Sentry. |
jeertmans
had a problem deploying
to
github-pages
GitHub Actions
Error
for more information, see https://pre-commit.ci
jeertmans
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to the progess made in ManimCommunity/manim#3501.
The following PR aims at reducing subprocess calls for security and speed reasons. Also, with ManimCommunity/manim#3501 is merged, FFMPEG should not be needed anymore as it is part of
PyAv.