Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(present): black video flashes and other bugs linked to Qt #465

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

jeertmans
Copy link
Owner

See #464 for original pull request. I did some mistakes but by pushing on my main branch instead of @PeculiarProgrammer 's main branch.

@jeertmans jeertmans added bug Something isn't working present Related to the main "present" feature qt Related to Qt (or its Python binding) labels Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.83%. Comparing base (3b23c77) to head (0da32ad).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   80.54%   77.83%   -2.72%     
==========================================
  Files          22       22              
  Lines        1835     1827       -8     
==========================================
- Hits         1478     1422      -56     
- Misses        357      405      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jeertmans
Copy link
Owner Author

@PeculiarProgrammer: did you check that #315 was fixed on Windows?

@taibeled
Copy link
Contributor

Yep. #315 was fixed.

@jeertmans
Copy link
Owner Author

Thanks @PeculiarProgrammer, I also ran some tests on Windows, both with PySide6 and PyQt6, and it worked (for PyQt6, I had to bump the minimal version, but looks good).

@jeertmans jeertmans merged commit 5b6f5eb into main Aug 26, 2024
30 of 42 checks passed
@jeertmans jeertmans deleted the fix-293 branch August 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working present Related to the main "present" feature qt Related to Qt (or its Python binding)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Device loss detected in Present() [BUG] Slides go black when video finishes
2 participants