Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(convert): blank web page when converting multiple slides into HTML #497

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

simanglam
Copy link
Contributor

@simanglam simanglam commented Dec 3, 2024

Fixes Issue

When manin-slides convert multiple slides into html, it add prefix to animation file in asset directory to prevent filename collision (as #428 mentioned) but doesn't add the prefix in HTML's reference to the file.

Description

I modified the HTML templates and pass prefix function to it.

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

See #496 also.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (3b62e6b) to head (1fcbca7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   81.07%   80.96%   -0.11%     
==========================================
  Files          23       23              
  Lines        1886     1886              
==========================================
- Hits         1529     1527       -2     
- Misses        357      359       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans added bug Something isn't working html-convert Related to converting to HTML slides labels Dec 3, 2024
@jeertmans jeertmans linked an issue Dec 3, 2024 that may be closed by this pull request
4 tasks
@jeertmans jeertmans changed the title fix(convert): Blank web page when converting multiple slides into HTML fix(convert): blank web page when converting multiple slides into HTML Dec 3, 2024
@jeertmans
Copy link
Owner

Hi @simanglam, thanks for this PR! It looks all good, but could you add some words about this in the CHANGELOG?

@simanglam
Copy link
Contributor Author

Hi @jeertmans, I've add some words about this in the CHANGELOG. Hope I didn't make any typo or grammar error.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Owner

@jeertmans jeertmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small change requested :)

@simanglam
Copy link
Contributor Author

Done!

@jeertmans
Copy link
Owner

Perfect, thanks @simanglam!

@jeertmans jeertmans merged commit 628c8da into jeertmans:main Dec 4, 2024
35 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html-convert Related to converting to HTML slides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Blank web page when converting multiple slides into HTML
2 participants