-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(convert): blank web page when converting multiple slides into HTML #497
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
- Coverage 81.07% 80.96% -0.11%
==========================================
Files 23 23
Lines 1886 1886
==========================================
- Hits 1529 1527 -2
- Misses 357 359 +2 ☔ View full report in Codecov by Sentry. |
Hi @simanglam, thanks for this PR! It looks all good, but could you add some words about this in the CHANGELOG? |
Hi @jeertmans, I've add some words about this in the CHANGELOG. Hope I didn't make any typo or grammar error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Small change requested :)
Done! |
Perfect, thanks @simanglam! |
Fixes Issue
When manin-slides convert multiple slides into html, it add prefix to animation file in asset directory to prevent filename collision (as #428 mentioned) but doesn't add the prefix in HTML's reference to the file.
Description
I modified the HTML templates and pass prefix function to it.
Check List
Check all the applicable boxes:
Screenshots
Note to reviewers
See #496 also.