Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(convert): avoid micro-stuttering with --one-file in HTML presentation #508

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

Rapsssito
Copy link
Contributor

@Rapsssito Rapsssito commented Jan 4, 2025

Description

As described in hakimel/reveal.js#3362 (reply in thread), currently, the base64 representation of the slide is loaded "on the fly" by RevealJS, which in results in a few frames of a blank screen. This solution is only executed once and updates all videos "src" attribute at the beginning of the presentation.

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (478552c) to head (5ddc945).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          23       23           
  Lines        1962     1962           
=======================================
  Hits         1561     1561           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rapsssito
Copy link
Contributor Author

@jeertmans, I am not sure if I should also update the docs/source/_static/template.html file...

@jeertmans
Copy link
Owner

Hi @Rapsssito, thanks for your PR!

@jeertmans, I am not sure if I should also update the docs/source/_static/template.html file...

Yes, please :)

@jeertmans jeertmans changed the title fix: Fix micro-stuttering with --one-file in HTML presentation fix(convert): avoid micro-stuttering with --one-file in HTML presentation Jan 4, 2025
@Rapsssito
Copy link
Contributor Author

Done!

Copy link
Owner

@jeertmans jeertmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rapsssito! Can you just add an entry to the CHANGELOG, in Changed?

@Rapsssito
Copy link
Contributor Author

Done!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@jeertmans jeertmans merged commit 840d1d8 into jeertmans:main Jan 9, 2025
9 of 12 checks passed
@jeertmans
Copy link
Owner

Thanks for your contribution @Rapsssito!

Rapsssito added a commit to Rapsssito/manim-slides that referenced this pull request Jan 14, 2025
jeertmans added a commit that referenced this pull request Jan 15, 2025
* fix(convert): fix missing slides after #508

* Update template.html

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>

---------

Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants