-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(convert): avoid micro-stuttering with --one-file in HTML presentation #508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 23 23
Lines 1962 1962
=======================================
Hits 1561 1561
Misses 401 401 ☔ View full report in Codecov by Sentry. |
@jeertmans, I am not sure if I should also update the |
Hi @Rapsssito, thanks for your PR!
Yes, please :) |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Rapsssito! Can you just add an entry to the CHANGELOG, in Changed?
Done! |
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Thanks for your contribution @Rapsssito! |
* fix(convert): fix missing slides after #508 * Update template.html * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Jérome Eertmans <jeertmans@icloud.com> --------- Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Description
As described in hakimel/reveal.js#3362 (reply in thread), currently, the base64 representation of the slide is loaded "on the fly" by RevealJS, which in results in a few frames of a blank screen. This solution is only executed once and updates all videos "src" attribute at the beginning of the presentation.
Check List
Check all the applicable boxes: