-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): add skip_animations
compatibility
#516
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 79.56% 79.51% -0.05%
==========================================
Files 23 23
Lines 1962 1972 +10
==========================================
+ Hits 1561 1568 +7
- Misses 401 404 +3 ☔ View full report in Codecov by Sentry. |
Hi @Rapsssito, thanks for your contribution! Small comments:
Many thanks! |
skip_animations
compatibilityskip_animations
compatibility
@jeertmans, I did test the code, but I just checked if the slide was indeed not there... My bad. I am sorry about my ignorance, but how can I test it in |
We don't need to go that far in the testing, especially as it would highly depend on where Manim stores partial animation files. But you could add a test that reads the |
Note, it might be interesting to document this new parameter here: manim-slides/manim_slides/slide/base.py Lines 298 to 341 in ef28230
and mention that it is passed to |
I have added the fix and the changelog. However, I am afraid I need your assistance with the tests. I was not able to execute them in my environment with
I have also added it, but reading the documentation, I would assume it is the same as (I actually did until I discovered it raised an Exception):
|
for more information, see https://pre-commit.ci
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
for more information, see https://pre-commit.ci
In case you missed it, the tests are still missing! I need your help with the implementation. |
I didn't miss, I was just waiting for your feedback on that :-) I will implement the tests myself then ;-) |
Thanks for your contribution @Rapsssito! |
Fixes Issue
Fixes #514
Description
As described in title.
Check List
Check all the applicable boxes: