Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant black hook & specify minimal supported python version for hooks #70

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

tdadela
Copy link
Contributor

@tdadela tdadela commented Nov 16, 2022

Description

  1. Remove redundant black hook introduced in 7128c01
  2. Specify minimal supported python version for hooks – black & isort.
    isort:
--py {all,2,27,3,310,35,36,37,38,39,auto}, --python-version {all,2,27,3,310,35,36,37,38,39,auto}
Tells isort to set the known standard library based on the specified Python version.
Default is to assume any Python 3 version could be the target, and use a union of all stdlib modules across versions.
If auto is specified, the version of the interpreter used to run isort (currently: 311) will be used.

black:

  -t, --target-version [py33|py34|py35|py36|py37|py38|py39|py310|py311]
                                  Python versions that should be supported by
                                  Black's output. [default: per-file auto-
                                  detection]

@jeertmans jeertmans added the ci Continous Integration (tests, lints, checks, ...) label Nov 16, 2022
@jeertmans
Copy link
Owner

Nice catch @tdadela, and that’s a good idea to specify the minimal Python version for all CI tools.

Many thanks for your contribution, merging this!

@jeertmans jeertmans merged commit 80f4f4e into jeertmans:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continous Integration (tests, lints, checks, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants