Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): feally featured RevealJS template #80

Merged
merged 12 commits into from
Dec 7, 2022
Merged

Conversation

jeertmans
Copy link
Owner

This adds an option for every possible RevealJS option. Error messages are also improved.

RevealJS version is bumped to latest (4.4.0).

This adds an option for every possible RevealJS option. Error messages are also improved.

RevealJS version is bumped to latest (4.4.0).
@jeertmans jeertmans added the enhancement New feature or request label Nov 30, 2022
@jeertmans jeertmans linked an issue Dec 7, 2022 that may be closed by this pull request
@jeertmans
Copy link
Owner Author

This PR fixes most of the issues mentioned @lucmos in #65, namely:

  • Framerate, Smooth Transition, and Keybindings: those can be achieved using a custom template, see manim-slides convert --help;
  • First animation is skipped: this was fixed by muting the audio, since most browsers prevent playing audio without the user first interacting, read this SO thread for more details;
  • Page Numbers: you can now configure them using config options.

For the Flashing background, I think this is a problem related to internet connection being slow or not, but this might need more investigation.

Therefore, I am closing #65 with this PR.

@jeertmans jeertmans merged commit c0c73ad into main Dec 7, 2022
@jeertmans jeertmans deleted the full-revealjs-config branch December 7, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Comparison with manim-editor
1 participant