Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implant dark mode #471

Merged
merged 17 commits into from
Dec 23, 2022
Merged

Implant dark mode #471

merged 17 commits into from
Dec 23, 2022

Conversation

YueMiyuki
Copy link
Contributor

Moved from #367

@jeessy2

@YueMiyuki YueMiyuki changed the title Change web/writing.html and static/common.css to implement dark mode Implement dark mode Dec 21, 2022
@jeessy2
Copy link
Owner

jeessy2 commented Dec 21, 2022

顶部背景/按钮是蓝色的?风格可以参考ant-design
截屏2022-12-21 下午8 09 53

@YueMiyuki
Copy link
Contributor Author

是要改么?不太明白你的意思

@jeessy2
Copy link
Owner

jeessy2 commented Dec 21, 2022

最好处理一下,这个暗黑模式看上去有点儿奇怪

@jeessy2
Copy link
Owner

jeessy2 commented Dec 21, 2022

输入框和蓝色的背景都需要处理。参考ant-design的暗黑模式
image

@YueMiyuki
Copy link
Contributor Author

YueMiyuki commented Dec 21, 2022

image
这样如何呢?

.navbar 改为渐变色

.navbar {
    /* background-color: #202225; */
    background-image: linear-gradient(#202225, #36393f) !important;
    color: #EEEEEE;
}

@jeessy2
Copy link
Owner

jeessy2 commented Dec 21, 2022

可以。BUTTON颜色保持bootstrap默认就好

@YueMiyuki
Copy link
Contributor Author

bootstrap颜色感觉太鲜艳了,比对下
Bootstrap:
image
更改后:
image

@jeessy2
Copy link
Owner

jeessy2 commented Dec 21, 2022

你去参考ant-design的暗黑模式吧,暗黑模式/白天模式的buttuon也没调色

@YueMiyuki
Copy link
Contributor Author

image
测试Webhook与保存按钮需要统一颜色吗?

@jeessy2
Copy link
Owner

jeessy2 commented Dec 22, 2022

统一啊,不统一不好看。save按钮太大了,保持和以前相同就好了

@YueMiyuki
Copy link
Contributor Author

感觉save按钮跟上面form持平会自然点,你觉得呢

@jeessy2
Copy link
Owner

jeessy2 commented Dec 22, 2022

button没看到占一整块的

可以参考下其它项目的暗色模式,输入框背景色,文本颜色,button样式
github https://github.com/new
截屏2022-12-22 上午10 14 34

ant-design的暗色模式 ant-design
截屏2022-12-21 下午8 09 53

@yin1999
Copy link
Contributor

yin1999 commented Dec 22, 2022

一个建议,有些人可能更喜欢亮色的主题,是否考虑使用 CSS 媒体查询加手动调整按钮。

@jeessy2
Copy link
Owner

jeessy2 commented Dec 22, 2022

一个建议,有些人可能更喜欢亮色的主题,是否考虑使用 CSS 媒体查询加手动调整按钮。

有肯定更好了

@YueMiyuki
Copy link
Contributor Author

可以有

@YueMiyuki
Copy link
Contributor Author

可以先看下 @jeessy2 @yin1999

@YueMiyuki
Copy link
Contributor Author

@jeessy2 可以了

@jeessy2
Copy link
Owner

jeessy2 commented Dec 22, 2022

  1. 默认亮色?
  2. 暗色select背景色需调整
  3. 暗色其它细节可以在优化下?颜色#FFFFFF,这个太白了,参考其它暗色模式的调整下

@yin1999
Copy link
Contributor

yin1999 commented Dec 22, 2022

可以参考这个,是可以通过媒体查询确定用户默认偏好的主题色:https://fe-blog.workplus.io/dark-mode-guide-on-web

@YueMiyuki
Copy link
Contributor Author

这样可以吗 @jeessy2 @yin1999

@YueMiyuki YueMiyuki changed the title Implement dark mode Implant dark mode Dec 23, 2022
@jeessy2
Copy link
Owner

jeessy2 commented Dec 23, 2022

暗色模式:输入框的边框颜色有点亮,有两个下拉框样式没调整,参考github/ant-design调整

@YueMiyuki
Copy link
Contributor Author

@jeessy2

@jeessy2
Copy link
Owner

jeessy2 commented Dec 23, 2022

通过网卡获取的背景色没改?
白天模式的日志的文本颜色不对

@YueMiyuki
Copy link
Contributor Author

@jeessy2

@jeessy2
Copy link
Owner

jeessy2 commented Dec 23, 2022

总体不错了。还有些地方不是很完善

  1. 通过网卡获取 有白色边框, 没统一,文本颜色也不统一
  2. 整体背景不是纯黑(有点偏灰),参考github调整下,其它细节也要调整

@YueMiyuki
Copy link
Contributor Author

参考GitHub主题做出了修改 @jeessy2

@jeessy2
Copy link
Owner

jeessy2 commented Dec 23, 2022

不错了。日志的文本大小调成15px了?感觉有点大了

@YueMiyuki
Copy link
Contributor Author

logs字体改回13px了

@YueMiyuki
Copy link
Contributor Author

@jeessy2

@jeessy2 jeessy2 merged commit 98326b3 into jeessy2:master Dec 23, 2022
@jeessy2
Copy link
Owner

jeessy2 commented Dec 23, 2022

@ItzMiracleOwO thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants