-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAGE_SLEEP_MIN being ignored? #510
Comments
Hi @daviderickson, just wondering if your running the latest nvidia-snatcher? if you haven't done an update in a while, it may be worth doing so, as this issue should have been resolved in #465 (comment). Alternately, you can try setting PAGE_SLEEP_MAX to 60000 as well, as this would be a workaround fix (if you haven't pulled a recent update/ or don't want to yet). Let us know if either of these resolve the issue for you 👍 |
Going to close and we can reopen if it ends up being a regression. Thanks @xninjax. |
Looks like intended behaviour, the 3080 FE has 2 entries using different pages IIRC, same as the 3090. I was also confused by this behaviour when I first used the project, like @daviderickson I expected |
That's correct. That being said, I was curious to make these requests to all the links parallel, since we aren't setting intervals between them. But not sure of the side effects. |
Agreed the multiple hits can appear broken/confusing at first, but indeed the script is confirmed only checking one set of links per series per batch (i.e every 60sec here). 2 links per series on nvidia sore ✔️
EDIT: Perhaps the PAGE_SLEEP_MIN/MAX definition could be improved to better reflect its current intended usage? PAGE_SLEEP_MIN | Minimum sleep time between queries of the same store | In milliseconds, default: 5000 Change to: PAGE_SLEEP_MIN | Minimum sleep time between queries of the same product page | In milliseconds, default: 5000 |
Description
Hi running on Windows 10, my .env has configured PAGE_SLEEP_MIN (and PAGE_BACKOFF_MIN) both to 60000, so I'd expect a 60 second minimum delay between queries to the same store. However from the log printout I'm getting:
[12:18:06 PM] info :: ✖ [nvidia] [nvidia (3080)] founders edition :: OUT OF STOCK
[12:18:10 PM] info :: ✖ [nvidia] [nvidia (3080)] founders edition :: OUT OF STOCK
[12:19:13 PM] info :: ✖ [nvidia] [nvidia (3080)] founders edition :: OUT OF STOCK
[12:19:17 PM] info :: ✖ [nvidia] [nvidia (3080)] founders edition :: OUT OF STOCK
Which looks to me like the min value isn't being respected by the backend.
Thanks!
The text was updated successfully, but these errors were encountered: