fix: max price getter updated to match .env #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g its intended usage
xninjax
changed the title
jef
approved these changes
Oct 13, 2020
|
Thank you!!! |
|
all good! 😄 🎉 |
AdamSaketume26
pushed a commit
to AdamSaketume26/nvidia-snatcher
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves max price not being checked, as getter in config.ts was not looking for correct max_price variables in .env
#514 MAX_PRICE_3080 not working
Minor documentation update also included to better reflect the usage of PAGE_SLEEP_MIN/MAX
#510 PAGE_SLEEP_MIN being ignored
Testing
Confirmed changes trigger max price filtering on test card (reconfigured as each series per test)
