Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): nvidia store changes #1797

Merged
merged 4 commits into from
Jan 26, 2021
Merged

fix(docs): nvidia store changes #1797

merged 4 commits into from
Jan 26, 2021

Conversation

YiIdirim
Copy link
Contributor

Description

  • Minor changes to the docs for better clarity.
  • Fixed hyperlink not working

If you could merge this @jef ASAP that would be great.

@YiIdirim YiIdirim requested a review from jef as a code owner January 26, 2021 12:40
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make sense! Thanks for the update. I'll merge after the suggestion change if you don't mind ☺️

docs/reference/filter.md Outdated Show resolved Hide resolved
@YiIdirim
Copy link
Contributor Author

This make sense! Thanks for the update. I'll merge after the suggestion change if you don't mind ☺️

Done! And I sneaked in a very minor addition to the Nvidia-GB store as I believe the buy button text has changed.

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks ☺️ 🚀

@jef jef merged commit de1427c into jef:main Jan 26, 2021
@YiIdirim YiIdirim deleted the minor-docs-fix branch January 26, 2021 13:45
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants