-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter models #261
Merged
feat: filter models #261
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6731bd5
feat: filter models
admon84 205065f
feat: filter models - log info on selected filters
admon84 7a1e59e
Merge branch 'upstream' into filter-model
admon84 7aff948
Merge branch 'upstream' into filter-model
admon84 51770cb
feat: filter models - santizing whitespace when comparing models to f…
admon84 f89ba93
Merge branch 'upstream' into filter-model
admon84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
import {Config} from '../config'; | ||
import {Link} from './model'; | ||
|
||
/** | ||
* Returns true if the brand should be checked for stock | ||
* | ||
* @param brand The brand of the GPU | ||
*/ | ||
function filterBrand(brand: Link['brand']): boolean { | ||
if (Config.store.showOnlyBrands.length === 0) { | ||
return true; | ||
} | ||
|
||
return Config.store.showOnlyBrands.includes(brand); | ||
} | ||
|
||
/** | ||
* Returns true if the model should be checked for stock | ||
* | ||
* @param model The model of the GPU | ||
*/ | ||
function filterModel(model: Link['model']): boolean { | ||
if (Config.store.showOnlyModels.length === 0) { | ||
return true; | ||
} | ||
|
||
const sanitizedModel = model.replace(/\s/g, ''); | ||
for (const configModel of Config.store.showOnlyModels) { | ||
const sanitizedConfigModel = configModel.replace(/\s/g, ''); | ||
if (sanitizedModel === sanitizedConfigModel) { | ||
return true; | ||
} | ||
} | ||
|
||
return false; | ||
} | ||
|
||
/** | ||
* Returns true if the series should be checked for stock | ||
* | ||
* @param series The series of the GPU | ||
*/ | ||
function filterSeries(series: Link['series']): boolean { | ||
if (Config.store.showOnlySeries.length === 0) { | ||
return true; | ||
} | ||
|
||
return Config.store.showOnlySeries.includes(series); | ||
} | ||
|
||
/** | ||
* Returns true if the link should be checked for stock | ||
* | ||
* @param link The store link of the GPU | ||
*/ | ||
export function filterStoreLink(link: Link): boolean { | ||
return ( | ||
filterBrand(link.brand) && | ||
filterModel(link.model) && | ||
filterSeries(link.series) | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
export * from './lookup'; | ||
export * from './includes-labels'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was on my todo list to refactor this out. Love it!