Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new paragraph behavior in Firefox #91

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jefago
Copy link
Owner

@jefago jefago commented Dec 13, 2024

Fixes #89.

When inserting a new paragraph, Firefox splits the div element in two, whereas Chromium inserts \n\n.

Changes:

  • When comparing which lines have changed (ie are dirty) after a paragraph insertion / deletion, also take into account the class name
  • Fix continuable type treatment in Firefox (don't return early when selection is at the beginning of the row after a paragraph break)

@jefago jefago merged commit 18f4bdc into main Dec 13, 2024
1 check passed
@jefago jefago deleted the fix-new-paragraph-behavior-firefox branch December 13, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: HR (horizontal divider) duplicating many times on enter key
1 participant