Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp/fix/#610 #612

Merged
merged 10 commits into from
Dec 10, 2022
Merged

Cpp/fix/#610 #612

merged 10 commits into from
Dec 10, 2022

Conversation

j-cortial
Copy link
Collaborator

@j-cortial j-cortial commented Nov 2, 2022

This PR fixes the sample code in #610 but is not a complete solution.
I would like to have your opinion on the fix before I go ahead and tackle raw string and character literals.

@j-cortial
Copy link
Collaborator Author

Now raw strings and (single-quoted) characters should be covered as well as standard double-quoted strings.

I did not use a scope beginning with keyword.other.unit.suffix since most suffixes (and especially string suffixes) have nothing to do with (physical) units.

The scope I used is keyword.other.suffix.literal.user-defined (to match the term used by https://en.cppreference.com/w/cpp/language/user_literal) and the refinement keyword.other.suffix.literal.user-defined.reserved when the suffix is reserved by the implementation (does not start with an underscore, such as the standard s and sv).

@jeff-hykin jeff-hykin merged commit d86bfb8 into jeff-hykin:master Dec 10, 2022
@jeff-hykin
Copy link
Owner

jeff-hykin commented Dec 10, 2022

Thanks again! Published in v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants