fix: update axios to 1.6.1 to fix CVE-2023-45857 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged sooner rather than later |
|
Thank you! |
|
@jeffbski Can this get some attention please? Thanks a lot. For more context: CVE-2023-45857 (CWE-359) XSRF-TOKEN value is disclosed to an unauthorised actor, fixed in axios 1.6.0. |
|
And update and a subsequent release would be great! |
mboere-seek
approved these changes
Nov 13, 2023
ghost
reviewed
Nov 13, 2023
package.json
Outdated
| @@ -38,7 +38,7 @@ | |||
| "temp": "^0.9.4" | |||
| }, | |||
| "dependencies": { | |||
| "axios": "^0.27.2", | |||
| "axios": "^1.6.0", | |||
There was a problem hiding this comment.
@porschesstein Thanks, updated. When I originally opened this PR, the latest version of Axios was still 1.6.0.
AndrewMax
changed the title
ghost
approved these changes
Nov 13, 2023
seanputera
approved these changes
Nov 14, 2023
|
Guess we'll just have to wait-on this PR. |
|
Tested locally and worked perfectly 🚀 |
wellwelwel
approved these changes
Nov 14, 2023
19 tasks
|
I hope this gets merged soon and then released! Looking forward... |
5 tasks
|
Thanks @AndrewMax for the PR and for those that confirmed it. It is published to wait-on@7.2.0 |
This was referenced Nov 14, 2023
facebook-github-bot
pushed a commit
to WhatsApp/erlang-language-platform
that referenced
this pull request
Nov 29, 2023
Summary: As per title. This avoids the axios vulnerability thanks to jeffbski/wait-on#147. Reviewed By: alanz Differential Revision: D51544987 fbshipit-source-id: f15a001aa1eaab14935cf521dd26dfa3938489e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axios was recently updated to fix CVE-2023-45857. This PR is to update to axios 1.6.0.