This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Switch to more generic location env vars #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mal I'm into this. Looks like it needs a rebase to merge in with the other changes you made recently. Once that's all set, I'll get this in, and ship everything. |
|
Thanks @jeffbyrnes, all rebased and mergable now 😀 |
jeffbyrnes
added a commit
that referenced
this pull request
Mar 3, 2015
Switch to more generic location env vars
jeffbyrnes
added a commit
that referenced
this pull request
Mar 3, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more explicit vars that can potentially be shared by other plugins needing to know the bot's geograhical location.
Inline with suggestion made here.