Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Visual Studio 2017 #1

Open
lethalshadow opened this issue Apr 22, 2017 · 8 comments
Open

Support for Visual Studio 2017 #1

lethalshadow opened this issue Apr 22, 2017 · 8 comments

Comments

@lethalshadow
Copy link

Could this extension be built for Visual Studio 2017 as well?

@jeffchen-codingconsultantco
Copy link
Owner

Hi @lethalshadow, I am working on it.

@OsirisTerje
Copy link

How is this proceeding?

@jeffchen-codingconsultantco
Copy link
Owner

@OsirisTerje , I have made some progress including refactor the project structure, and adding new code. Currently, I am blocked by a issue that VS2017 does not trigger data point creation code which is used to trigger the code for metric calculation.

@brukwa
Copy link

brukwa commented Apr 28, 2018

I had the same problem with VS 2017, but it turned out to be a problem with ICodeLensDataPointProvider implementation.

Try adding an Importing constructor

[ImportingConstructor]
public DataPointProvider([Import(typeof(SVsServiceProvider))] IServiceProvider service, IVisualStudioIntegrationService integration)
{
/// ... some ctor body
}

Also I have switched to Microsoft.VisualStudio.CodeSense.Roslyn which contains the Microsoft.VisualStudio.Alm.Roslyn.Client namespace

The SVsServiceProvider type can be found in public Microsoft.VisualStudio.Shell.Framework assembly.

@jeffchen-codingconsultantco
Copy link
Owner

@brukwa , thank you for your help. I will give it a try.

@norcino
Copy link

norcino commented Feb 16, 2019

Hi @jeffchen-codingconsultantco , my guess is that you abandoned the project, am I right?

@jeffchen-codingconsultantco
Copy link
Owner

jeffchen-codingconsultantco commented Feb 26, 2019

Hi @jeffchen-codingconsultantco , my guess is that you abandoned the project, am I right?

Microsoft has opened CodeLens API for 3rd party extension. I guess I will have a look if there is a chance to migrate to official API. However, I guess other extension vendor has already started to provide new functionality base on this new API.

@brukwa
Copy link

brukwa commented Feb 26, 2019

Well it is somewhat official: VSSDK-Extensibility-Samples
From what I saw theses classes are even documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@OsirisTerje @lethalshadow @brukwa @norcino @jeffchen-codingconsultantco and others