-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise suggestion #54
Comments
I'm open to this. Could you show me how you would implement it? |
hey jeff, I think it's not very difficult probably. We can just try to replace the Promise by |
Sounds good! |
AllenFang
added a commit
to AllenFang/jest-fetch-mock
that referenced
this issue
Apr 1, 2018
jefflau
added a commit
that referenced
this issue
May 16, 2018
fix #54: allow Promise to support Promise.finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @jefflau
Preface
About
Promise.finally
is already going to stage 4, some promise library already supportfinally
function.Issue
Recently, I used
finally
withfetch
in my code, everything is work well, but when I writing the test leverage byjest-fetch-mock
, there's something wrong. Anyway, the modern browser's fetch already support finally except for Edge. you can try it easily on browser dev toolRoot cause
I think due to
jest-fetch-mock
still use native Promise so that some people will got above issue.Do you consider to use
promise-polyfill
to fix this issue?, it's already supportfinally
Probably, I can try to fix this issue by a PR after your confirmation
The text was updated successfully, but these errors were encountered: