Update to support GITHUB_TOKEN #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge changes
jeffreytse
reviewed
Oct 5, 2021
There was a problem hiding this comment.
The ACTOR variable has been defined, we should keep use it, and its default value is the same as GITHUB_ACTION.
perf: revise actor variable
jeffreytse
reviewed
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a personal access token is strongly discouraged by GITHUB because it is a serious security risk. This PR updates the action to use the standard GITHUB_TOKEN which can be limited in scope and is re-generated after each workflow run.
I have tested it on my own repository using a GH_TOKEN and a GITHUB_TOKEN and it works for both, so existing users will not be required to update their code if they do not want to.