Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix href bug on post-tag in _includes/views/pagination.html #31

Merged
merged 1 commit into from
May 2, 2021
Merged

Fix href bug on post-tag in _includes/views/pagination.html #31

merged 1 commit into from
May 2, 2021

Conversation

MarkChenYutian
Copy link
Contributor

The original hyperlink will fail when the {{ site.baseurl }} is not "/". I fixed the problem by applying liquid filter "relative_url" on the auto-generated code.

@jeffreytse jeffreytse self-requested a review May 2, 2021 14:29
@jeffreytse jeffreytse self-assigned this May 2, 2021
@jeffreytse jeffreytse added the bug Something isn't working label May 2, 2021
@MarkChenYutian
Copy link
Contributor Author

Sorry, I'm a novice developer and it seems that I forgot to apply "bug" Label on this PR.

Copy link
Owner

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug as you said, we use the liquid filter of relative_url fixes this issue.

@jeffreytse
Copy link
Owner

Hi @MarkChenYutian

Thanks for the PR and welcome to star this project for further updates in the future.

Thanks and regards

@jeffreytse jeffreytse merged commit 1bd2664 into jeffreytse:master May 2, 2021
shahbaz22 pushed a commit to shahbaz22/resonance-site that referenced this pull request Nov 17, 2024
Co-authored-by: Mark Chen <markchenyutian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants