Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyrillic font support #288

Closed
senyaa1 opened this issue Oct 9, 2023 · 1 comment · Fixed by #304
Closed

Cyrillic font support #288

senyaa1 opened this issue Oct 9, 2023 · 1 comment · Fixed by #304
Labels
enhancement New feature or request

Comments

@senyaa1
Copy link
Contributor

senyaa1 commented Oct 9, 2023 •
edited
Loading

What do you want to be added?

Support for cyrillic fonts. Cyrillic texts revert to a standard serif font.
@senyaa1 senyaa1 added the enhancement New feature or request label Oct 9, 2023
@Nik-mmzd
Copy link

Kinda duplicate of #270?

kgarner7 added a commit to kgarner7/feishin that referenced this issue Oct 14, 2023
@kgarner7
[feature]: Support using system fonts
db24f85 
Uses the **experimental** queryLocalFonts API, when prompted, to get the fonts and do CSS.
Resolves jeffvli#270 and jeffvli#288 (by proxy)

Caveats/notes:
- This is experimental, and is only supported by Chrome/Chromium/Edgeium (see https://caniuse.com/?search=querylocalfonts)
- As far as I can tell, the only way to dynamically change the font (shown in https://wicg.github.io/local-font-access/#example-style-with-local-fonts) was by DOM manipulation; css variables did not seem to work
- This shows **all** fonts, including their variants (bold/italic/etc); given that the style names could be localized, not sure of a way to parse this (on my system, for instance, I had 859 different combinations)
- I made fonts a separate top-level setting because it was easier to manipulate without causing as many rerenders; feel free to put that back
@kgarner7 kgarner7 mentioned this issue Oct 14, 2023
Merged
jeffvli pushed a commit that referenced this issue Oct 22, 2023
@kgarner7
[feature]: Support using system fonts (#304)
74cab01 
* [feature]: Support using system fonts

Uses the **experimental** queryLocalFonts API, when prompted, to get the fonts and do CSS.
Resolves #270 and #288 (by proxy)

Caveats/notes:
- This is experimental, and is only supported by Chrome/Chromium/Edgeium (see https://caniuse.com/?search=querylocalfonts)
- As far as I can tell, the only way to dynamically change the font (shown in https://wicg.github.io/local-font-access/#example-style-with-local-fonts) was by DOM manipulation; css variables did not seem to work
- This shows **all** fonts, including their variants (bold/italic/etc); given that the style names could be localized, not sure of a way to parse this (on my system, for instance, I had 859 different combinations)
- I made fonts a separate top-level setting because it was easier to manipulate without causing as many rerenders; feel free to put that back

* add permission chec

* add electron magic to support custom font

* restrict content types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature]: Support using system fonts kgarner7/feishin
2 participants
@Nik-mmzd @senyaa1