Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: Remove setting path in attempt to bypass bug #344

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

kgarner7
Copy link
Collaborator

@kgarner7 kgarner7 commented Nov 1, 2023

Maybe resolves #343? I can't verify because the issue doesn't happen for me, but this appears to be the symptom at least...

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 4:03am

@jeffvli
Copy link
Owner

jeffvli commented Nov 1, 2023

Yeah, that seems to be it.

If this doesn't fix it, you could do what I did with the mpv executable path and just remove the defaultValue and set the raw path string as a placeholder.

@jeffvli jeffvli marked this pull request as ready for review November 1, 2023 03:33
@kgarner7
Copy link
Collaborator Author

kgarner7 commented Nov 1, 2023

Placeholder is probably a better option anyway, so let's go with that

@jeffvli jeffvli merged commit 6bd836f into jeffvli:development Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings crash after setting custom system font
2 participants