[bugfix] Fix global hotkeys not working on startup #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kgarner7
reviewed
Feb 4, 2024
src/main/main.ts
Outdated
| @@ -635,7 +635,7 @@ ipcMain.on( | |||
|
|
|||
| const globalMediaKeysEnabled = store.get('global_media_hotkeys') as boolean; | |||
|
|
|||
| if (globalMediaKeysEnabled) { | |||
| if (globalMediaKeysEnabled !== false) { | |||
There was a problem hiding this comment.
Rather than changing the condition, a potentially more clear option would be store.get('global_media_hotkeys', true) as boolean (true being the default when not defined).
There was a problem hiding this comment.
I didn't know that was a thing, I'll definitely use that instead to clear up the code.
iiPythonx
changed the title
|
That should do it, testing shows that it still works and I'm not sure of any other improvements to make to it. |
|
Thanks! |
This was referenced Feb 4, 2024
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
Mar 16, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/jeffvli/feishin](https://github.com/jeffvli/feishin) | minor | `0.5.3` -> `0.6.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jeffvli/feishin (ghcr.io/jeffvli/feishin)</summary> ### [`v0.6.1`](https://github.com/jeffvli/feishin/releases/tag/v0.6.1): 0.6.1 [Compare Source](https://github.com/jeffvli/feishin/compare/v0.6.0...v0.6.1) ##### Fixed - (Navidrome) Fixed application becoming stuck when Navidrome credential session times out ([#​538](https://github.com/jeffvli/feishin/issues/538)) ##### Other - Downgraded from Electron v27 to v26 to restore compatibility with macOS 10.13 and 10.14 ([#​534](https://github.com/jeffvli/feishin/issues/534)) ### [`v0.6.0`](https://github.com/jeffvli/feishin/releases/tag/v0.6.0): 0.6.0 [Compare Source](https://github.com/jeffvli/feishin/compare/v0.5.3...v0.6.0) 0.6.0 is here! Due to the large number of updates in this version, there may be undocumented changes that are not listed here. ##### Docker Added a way for a static server to be configured for the dockerized version of Feishin. Check the [docker compose](https://github.com/jeffvli/feishin/blob/development/docker-compose.yaml) for new environment variables configuration. #### Added - URLs in the `Note` column are now formatted as links - External resource (last.fm, musicbrainz) links are now optionally displayed on the album and artist pages - Album pages now show description if available - Added dynamic image background option in fullscreen player ([#​526](https://github.com/jeffvli/feishin/issues/526)) (Thanks [@​iiPythonx](https://github.com/iiPythonx)) - Added additional `mpris` metadata fields - audioBpm - comment - contentCreated - lastUsed - userRating - Added options to clear the Feishin HTTP and Query cache to clear stored lyrics - Added related songs to the `Related` tab on the fullscreen player - Added `codec` column for song lists - Added option to start app as minimized #### Changed - Playback speed control is now a slider instead of a selection ([#​437](https://github.com/jeffvli/feishin/issues/437)) (Thanks [@​marksdestiny](https://github.com/marksdestiny)) - Web player is now the default instead of MPV - (Jellyfin) Adding a jellyfin server now allows for an empty password field - Default hotkey for play/pause toggle set to SPACEBAR - Changed icon for `Play Random` on the player bar #### Fixed - (Jellyfin) Fixed getPlaylistSongList endpoint only returning the first 300 songs ([#​449](https://github.com/jeffvli/feishin/issues/449)) (Thanks [@​SlyFabi](https://github.com/SlyFabi)) - Properly set native titlebar on macOS ([#​209](https://github.com/jeffvli/feishin/issues/209)) (Thanks [@​kgarner7](https://github.com/kgarner7)) - Fixed long artist page descriptions not being truncated - Fixed playback when SHUFFLE and REPEAT ONE is enabled and there is only one track in the queue - (MPV) Fixed audio sample rate value on startup ([#​470](https://github.com/jeffvli/feishin/issues/470)) (Thanks [@​kgarner7](https://github.com/kgarner7)) - Player buttons are now disabled when the queue is empty - Fixed play queue scroll position changing when app window focus changes - Fixed scrobbling condition when a song is repeated - Fixed volume when set by MPRIS - Fixed player index being offset by 1 when restoring queue on startup - Various translation fixes #### What's Changed - AppImage: Set proper categories on desktop entry by [@​mihawk90](https://github.com/mihawk90) in [https://github.com/jeffvli/feishin/pull/430](https://github.com/jeffvli/feishin/pull/430) - Update scrobble-settings.tsx by [@​salguerooo](https://github.com/salguerooo) in [https://github.com/jeffvli/feishin/pull/440](https://github.com/jeffvli/feishin/pull/440) - Use startIndex in Jellyfin getPlaylistSongList by [@​SlyFabi](https://github.com/SlyFabi) in [https://github.com/jeffvli/feishin/pull/449](https://github.com/jeffvli/feishin/pull/449) - Improve the playback speed control by [@​marksdestiny](https://github.com/marksdestiny) in [https://github.com/jeffvli/feishin/pull/437](https://github.com/jeffvli/feishin/pull/437) - Bump axios from 1.5.1 to 1.6.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/459](https://github.com/jeffvli/feishin/pull/459) - Bump zod from 3.21.4 to 3.22.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/460](https://github.com/jeffvli/feishin/pull/460) - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.22.19 to 7.23.7 by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/462](https://github.com/jeffvli/feishin/pull/462) - Bump postcss from 8.4.27 to 8.4.33 by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/463](https://github.com/jeffvli/feishin/pull/463) - Bump electron from 25.3.0 to 25.8.4 in /release/app by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/464](https://github.com/jeffvli/feishin/pull/464) - Bump follow-redirects from 1.15.2 to 1.15.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/461](https://github.com/jeffvli/feishin/pull/461) - Fixed incorrect label for album sort by release date by [@​rappo](https://github.com/rappo) in [https://github.com/jeffvli/feishin/pull/458](https://github.com/jeffvli/feishin/pull/458) - Add frame to macOS native window bar by [@​jeffvli](https://github.com/jeffvli) in [https://github.com/jeffvli/feishin/pull/209](https://github.com/jeffvli/feishin/pull/209) - \[bugfix]: defer restore queue until mpv exists by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/435](https://github.com/jeffvli/feishin/pull/435) - \[bugfix]: Validate audio sample range, catch AudioContext error by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/470](https://github.com/jeffvli/feishin/pull/470) - \[bugfix]: Fix add to playlist success message by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/473](https://github.com/jeffvli/feishin/pull/473) - \[bugfix]: Fix safari audio context by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/471](https://github.com/jeffvli/feishin/pull/471) - \[enhancement]: support clearing query and http cache by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/475](https://github.com/jeffvli/feishin/pull/475) - \[bugfix]: Fix repeated track scrobbling by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/480](https://github.com/jeffvli/feishin/pull/480) - \[feature]: Show album comment, Last.fm/MusicBrainz links by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/450](https://github.com/jeffvli/feishin/pull/450) - \[bugfix/enhancement] Order artist's Top Songs by play count by [@​lymnyx](https://github.com/lymnyx) in [https://github.com/jeffvli/feishin/pull/487](https://github.com/jeffvli/feishin/pull/487) - \[enhancement] Add a button size setting by [@​iiPythonx](https://github.com/iiPythonx) in [https://github.com/jeffvli/feishin/pull/486](https://github.com/jeffvli/feishin/pull/486) - \[bugfix] Fix global hotkeys not working on startup by [@​iiPythonx](https://github.com/iiPythonx) in [https://github.com/jeffvli/feishin/pull/488](https://github.com/jeffvli/feishin/pull/488) - \[bugfix] Fixes route of most played songs on home page by [@​lymnyx](https://github.com/lymnyx) in [https://github.com/jeffvli/feishin/pull/489](https://github.com/jeffvli/feishin/pull/489) - \[bugfix/enhancement] Fixes german translations being sentence-case by [@​lymnyx](https://github.com/lymnyx) in [https://github.com/jeffvli/feishin/pull/491](https://github.com/jeffvli/feishin/pull/491) - \[bugfix]: default go libsecret, support changing secret store by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/493](https://github.com/jeffvli/feishin/pull/493) - Bump the npm_and_yarn group across 2 directories with 2 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/500](https://github.com/jeffvli/feishin/pull/500) - \[enhancement]: Audio player enhancements by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/501](https://github.com/jeffvli/feishin/pull/501) - \[bugfix/enhancement]: Support Navidrome structured lyrics by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/484](https://github.com/jeffvli/feishin/pull/484) - \[enhancement]: support reordering homepage by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/494](https://github.com/jeffvli/feishin/pull/494) - Image Resolution Setting by [@​darkpixlz](https://github.com/darkpixlz) in [https://github.com/jeffvli/feishin/pull/492](https://github.com/jeffvli/feishin/pull/492) - \[bugfix]: Macos trusted accessibility by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/512](https://github.com/jeffvli/feishin/pull/512) - Bump the npm_and_yarn group across 2 directories with 1 update by [@​dependabot](https://github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/521](https://github.com/jeffvli/feishin/pull/521) - \[enhancement]: Start minimized by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/522](https://github.com/jeffvli/feishin/pull/522) - Add a pre-defined server for the docker version by [@​Kakoluz](https://github.com/Kakoluz) in [https://github.com/jeffvli/feishin/pull/413](https://github.com/jeffvli/feishin/pull/413) - \[enhancement]: Better version checks by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/514](https://github.com/jeffvli/feishin/pull/514) - \[bugfix]: Check for Navidrome authentication on startup by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/510](https://github.com/jeffvli/feishin/pull/510) - \[enhancement]: Differentiate shared and owner playlists for Navidrome by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/517](https://github.com/jeffvli/feishin/pull/517) - \[enhancement]: Make related tab on full screen player useful by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/519](https://github.com/jeffvli/feishin/pull/519) - \[enhancements]: fix carousel, full screen metadata improvements by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/524](https://github.com/jeffvli/feishin/pull/524) - \[feat] Add a dynamic image option to the fullscreen player by [@​iiPythonx](https://github.com/iiPythonx) in [https://github.com/jeffvli/feishin/pull/526](https://github.com/jeffvli/feishin/pull/526) - \[enhancement]: better version checks for lyrics, Navidrome by [@​kgarner7](https://github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/529](https://github.com/jeffvli/feishin/pull/529) #### New Contributors - [@​mihawk90](https://github.com/mihawk90) made their first contribution in [https://github.com/jeffvli/feishin/pull/430](https://github.com/jeffvli/feishin/pull/430) - [@​salguerooo](https://github.com/salguerooo) made their first contribution in [https://github.com/jeffvli/feishin/pull/440](https://github.com/jeffvli/feishin/pull/440) - [@​SlyFabi](https://github.com/SlyFabi) made their first contribution in [https://github.com/jeffvli/feishin/pull/449](https://github.com/jeffvli/feishin/pull/449) - [@​marksdestiny](https://github.com/marksdestiny) made their first contribution in [https://github.com/jeffvli/feishin/pull/437](https://github.com/jeffvli/feishin/pull/437) - [@​dependabot](https://github.com/dependabot) made their first contribution in [https://github.com/jeffvli/feishin/pull/459](https://github.com/jeffvli/feishin/pull/459) - [@​rappo](https://github.com/rappo) made their first contribution in [https://github.com/jeffvli/feishin/pull/458](https://github.com/jeffvli/feishin/pull/458) - [@​lymnyx](https://github.com/lymnyx) made their first contribution in [https://github.com/jeffvli/feishin/pull/487](https://github.com/jeffvli/feishin/pull/487) - [@​darkpixlz](https://github.com/darkpixlz) made their first contribution in [https://github.com/jeffvli/feishin/pull/492](https://github.com/jeffvli/feishin/pull/492) **Full Changelog**: jeffvli/feishin@v0.5.3...v0.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI0MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318, #404, and #477 which was caused just by a broken comparison. Not sure why the value is
undefinedwhen it's set totrue, but at least now the statements are consistent and global hotkeys work on startup.(tested and working, if it doesn't work then maybe theres a deeper issue, not sure)