Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LrcLib fetcher #603

Merged
merged 1 commit into from
May 2, 2024

Conversation

vukanovics
Copy link
Contributor

LrcLib expects durations in seconds, while the duration field in Feishin is normalized to milliseconds.
This causes the lyrics fetch to fail.

Convert the normalized duration into seconds.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 11:13am

@kgarner7 kgarner7 merged commit 297d6f0 into jeffvli:development May 2, 2024
2 checks passed
@kgarner7
Copy link
Collaborator

kgarner7 commented May 2, 2024

Thanks!

spiceratops referenced this pull request in spiceratops/k8s-gitops May 7, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/jeffvli/feishin](https://github.com/jeffvli/feishin) |
minor | `0.6.1` -> `0.7.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>jeffvli/feishin (ghcr.io/jeffvli/feishin)</summary>

###
[`v0.7.1`](https://github.com/jeffvli/feishin/releases/tag/v0.7.1):
0.7.1

[Compare
Source](https://github.com/jeffvli/feishin/compare/v0.7.0...v0.7.1)

0.7.1 released to fix missing Windows binary.

**Full Changelog**:
jeffvli/feishin@v0.7.0...v0.7.1

###
[`v0.7.0`](https://github.com/jeffvli/feishin/releases/tag/v0.7.0):
0.7.0

[Compare
Source](https://github.com/jeffvli/feishin/compare/v0.6.1...v0.7.0)

0.7.0 is here!

Moving forwards, release notes will be simplified as so. Thanks to all
the contributors as always!

#### Highlights

- (UI) Added `Get Info` button on dropdowns to show extended details for
the selected item
-   (UI) Changed titlebar on light theme to use a lighter color
- (UI) Error page now shows server menu in case to handle cases where
application can become stuck
- (UI) Fixed synchronized lyrics not repeating when track is repeated on
fullscreen player
- (UI) Added toggle to switch between tracks and albums when double
clicking an item in the genres list
-   (UI) (Jellyfin) Fixed lyrics parsing for Jellyfin v10.9.0
-   (UI) (Navidrome) Adds `Share item` to item context menus
- (UI) (Navidrome) Added `inPlaylist` and `notInPlaylist` operators for
Navidrome smart playlists
- (UI) (Navidrome) Added JSON preview for smart playlist builder output
- (UI) Added Farsi and Chinese (Traditional) languages (thanks to
translators!)
- (Desktop) The positioning state of the application is now persisted
(maximize, fullscreen, window position)
- (Player) Various fixes/improvements with player implementation
including mpris and scrobbling
- ...and more: [view
commits](https://github.com/jeffvli/feishin/compare/v0.6.1...v0.7.0)

#### What's Changed

- Bump the npm_and_yarn group across 1 directory with 2 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/542](https://github.com/jeffvli/feishin/pull/542)
- Bump the npm_and_yarn group across 1 directory with 1 update by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/551](https://github.com/jeffvli/feishin/pull/551)
- Bump the npm_and_yarn group across 1 directory with 1 update by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/557](https://github.com/jeffvli/feishin/pull/557)
- Bump the npm_and_yarn group across 1 directory with 1 update by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/561](https://github.com/jeffvli/feishin/pull/561)
- \[bugfix]: Resolve MPV next/prev race condition by
[@&#8203;kgarner7](https://github.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/566](https://github.com/jeffvli/feishin/pull/566)
- \[bugfix]: Add a fallback image to the dynamic background url by
[@&#8203;iiPythonx](https://github.com/iiPythonx) in
[https://github.com/jeffvli/feishin/pull/571](https://github.com/jeffvli/feishin/pull/571)
- \[enhancement]: Show item details by
[@&#8203;kgarner7](https://github.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/573](https://github.com/jeffvli/feishin/pull/573)
- Fix portrait mode detection by
[@&#8203;Kaydax](https://github.com/Kaydax) in
[https://github.com/jeffvli/feishin/pull/582](https://github.com/jeffvli/feishin/pull/582)
- \[enhancement]: Support react-router links in Modal by
[@&#8203;kgarner7](https://github.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/586](https://github.com/jeffvli/feishin/pull/586)
- \[enhancement]: Support toggling Album/Track view for gneres by
[@&#8203;kgarner7](https://github.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/591](https://github.com/jeffvli/feishin/pull/591)
- Implement Navidrome sharing by
[@&#8203;iiPythonx](https://github.com/iiPythonx) in
[https://github.com/jeffvli/feishin/pull/575](https://github.com/jeffvli/feishin/pull/575)
- \[bugfix]: Handle top-level songs for Jellyfin by
[@&#8203;kgarner7](https://github.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/553](https://github.com/jeffvli/feishin/pull/553)
- Bump ejs from 3.1.9 to 3.1.10 in the npm_and_yarn group across 1
directory by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jeffvli/feishin/pull/602](https://github.com/jeffvli/feishin/pull/602)
- Fix LrcLib fetcher by
[@&#8203;vukanovics](https://github.com/vukanovics) in
[https://github.com/jeffvli/feishin/pull/603](https://github.com/jeffvli/feishin/pull/603)
- Allow smaller album covers in card/poster display by
[@&#8203;Dylancyclone](https://github.com/Dylancyclone) in
[https://github.com/jeffvli/feishin/pull/598](https://github.com/jeffvli/feishin/pull/598)
- Add new Navidrome smart playlist operators (up to v0.52.0) by
[@&#8203;jeffvli](https://github.com/jeffvli) in
[https://github.com/jeffvli/feishin/pull/604](https://github.com/jeffvli/feishin/pull/604)

#### New Contributors

- [@&#8203;Kaydax](https://github.com/Kaydax) made their first
contribution in
[https://github.com/jeffvli/feishin/pull/582](https://github.com/jeffvli/feishin/pull/582)
- [@&#8203;vukanovics](https://github.com/vukanovics) made their first
contribution in
[https://github.com/jeffvli/feishin/pull/603](https://github.com/jeffvli/feishin/pull/603)
- [@&#8203;Dylancyclone](https://github.com/Dylancyclone) made their
first contribution in
[https://github.com/jeffvli/feishin/pull/598](https://github.com/jeffvli/feishin/pull/598)

**Full Changelog**:
jeffvli/feishin@v0.6.1...v0.7.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDcuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants