Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory support for static files #408

Merged
merged 14 commits into from
Nov 11, 2019

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Jun 25, 2017

  • Update API
  • Add front-end support
  • add coverage
  • Update documentation

Partially resolves #201

/admin/staticfiles/assets

(sample user directory)

static-dirs

/admin/staticfiles/index

(static page. no other actions)

static-index

@ashmaroli
Copy link
Member Author

@mertkahyaoglu @benbalter Did you guys get a chance to look into this?

@mertkahyaoglu
Copy link
Member

mertkahyaoglu commented Jul 1, 2017

Tested locally. It's looking great. Great job 👍
I'm going to make a full review soon.

@gengsa
Copy link

gengsa commented Aug 26, 2017

@ashmaroli How about read some diretory from _config.yml, so i can specify my own config. Or even directory to the sub-folder. Look forward to your submission.

@ashmaroli
Copy link
Member Author

@gengsa can you elaborate a little bit more.. with a small example?
Also, this feature is currently available via jekyll-manager if you want to give it a try..

@gengsa
Copy link

gengsa commented Aug 26, 2017

@ashmaroli I have tried your jekyll-manager. I want to specify my own static files base directory, like /images or /assets/images. And with some sub-directory, just like

/images/image1.png,
/images/foods/images2.png,
/images/foods/image3.png,

Maybe some other directory. Thank you very much.

@gengsa
Copy link

gengsa commented Aug 26, 2017

@ashmaroli Thanks for your jekyll-manager, it's what i want. Hope you merge into jekyll/jekyll-admin. Thanks very much.

@ashmaroli
Copy link
Member Author

Many of the features in jekyll-manager are already under review for merge into Jekyll Admin..
Only a matter of time..

@renshuki
Copy link

renshuki commented Mar 9, 2019

Any plan to merge this PR? It would be great.

@mertkahyaoglu
Copy link
Member

Could merge this when conflicts are resolved.

@ashmaroli
Copy link
Member Author

@mertkahyaoglu The conflicts are too complex for me to resolve. Will you be able to handle them..? Else, I shall close this..

@mertkahyaoglu
Copy link
Member

@ashmaroli Ok. I take a look at it.

@BeMrTeal
Copy link

HI all,

Any update on this?

Kind regards,

@ashmaroli ashmaroli merged commit 721dd16 into jekyll:master Nov 11, 2019
@ashmaroli ashmaroli deleted the static-file-dirs branch November 11, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Specify folder to upload static files to
5 participants