Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter away virtual pages that output to HTML file #520

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Filter away virtual pages that output to HTML file #520

merged 1 commit into from
Oct 18, 2019

Conversation

ashmaroli
Copy link
Member

There is no point in rendering routes to virtual pages—those that do not have a physical presence within the source directory. Such page objects are always generated via a plugin.

For example, jekyll-redirect-from plugin generates a virtual page named redirect.html. Such pages exist only in-memory at runtime.

Fixes #428

@ashmaroli
Copy link
Member Author

That was fast 😃

@ashmaroli ashmaroli merged commit 2abaa03 into jekyll:master Oct 18, 2019
@ashmaroli ashmaroli deleted the filter-redirect-pages branch October 18, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertkahyaoglu mertkahyaoglu mertkahyaoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An inconsistency due to jekyll-redirect-from
2 participants
@ashmaroli @mertkahyaoglu