Add relative_path field in API response #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For resources that respond to `relative_path` calls, expose the value after stripping away any leading slashes and special dirnames from them Refer private method `JekyllAdmin::APIable#relative_path_for_api` for examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For resources that respond to
relative_pathcalls, expose the value after stripping away any leading slashes and special dirnames from them.The rationale is that front end does not ever send a request to the URI containing a resource's special directory (where applicable). The sanitized relative path is either sent with the initial payload or constructed via front end logic.
This change normalizes the behavior for all resources and allows simplifying front end code.