Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating Open Collective #526

Merged
merged 2 commits into from
Feb 29, 2020
Merged

Activating Open Collective #526

merged 2 commits into from
Feb 29, 2020

Conversation

monkeywithacupcake
Copy link
Contributor

Hi, I'm making updates for Open Collective. Either you or another core contributor signed this repository up for Open Collective. This pull request adds financial contributors from your Open Collective https://opencollective.com/jekyll-admin ❤️

What it does:

  • adds a badge to show the latest number of financial contributors
  • adds a banner displaying contributors to the project on GitHub
  • adds a banner displaying all individuals contributing financially on Open Collective
  • adds a section displaying all organizations contributing financially on Open Collective, with their logo and a link to their website

P.S: As with any pull request, feel free to comment or suggest changes.

Thank you for your great contribution to the Open Source community. You are awesome! 🙌
And welcome to the Open Collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other Open Source sustainers!

Copy link
Member

@mertkahyaoglu mertkahyaoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 💯 Thanks @monkeywithacupcake.

Just a minor comment. Then we can bring this in.

README.md Outdated
@@ -1,4 +1,4 @@
[![Gem Version](https://img.shields.io/gem/v/jekyll-admin.svg)](https://rubygems.org/gems/jekyll-admin)
[![Financial Contributors on Open Collective](https://opencollective.com/jekyll-admin/all/badge.svg?label=financial+contributors)](https://opencollective.com/jekyll-admin) [![Gem Version](https://img.shields.io/gem/v/jekyll-admin.svg)](https://rubygems.org/gems/jekyll-admin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to move this at the end of other badges.

@ashmaroli
Copy link
Member

FYI: Jekyll has the info split into two badges:

[![Backers on Open Collective](https://opencollective.com/jekyll/backers/badge.svg)](#backers)
[![Sponsors on Open Collective](https://opencollective.com/jekyll/sponsors/badge.svg)](#sponsors)

@mattr-
Copy link
Member

mattr- commented Oct 31, 2019

👋 Rather than setting up an open collective specifically for Jekyll Admin, what do you think about just leveraging Jekyll's existing open collective?

@mertkahyaoglu
Copy link
Member

@mattr- I feel like Jekyll Admin is a bit disconnected from Jekyll so i think this is ok 👍

@mattr-
Copy link
Member

mattr- commented Nov 1, 2019

@mertkahyaoglu Cool. Just thought I would offer since we share the same github org and have plenty of backers and funders that could be useful to this project as well. 😄

moved Financial Contributors to the end of the badges.
<a href="https://opencollective.com/jekyll-admin/organization/6/website"><img src="https://opencollective.com/jekyll-admin/organization/6/avatar.svg"></a>
<a href="https://opencollective.com/jekyll-admin/organization/7/website"><img src="https://opencollective.com/jekyll-admin/organization/7/avatar.svg"></a>
<a href="https://opencollective.com/jekyll-admin/organization/8/website"><img src="https://opencollective.com/jekyll-admin/organization/8/avatar.svg"></a>
<a href="https://opencollective.com/jekyll-admin/organization/9/website"><img src="https://opencollective.com/jekyll-admin/organization/9/avatar.svg"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, why are there 10 links here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is placeholders that allow for you to get up to 10 sponsors before you have to edit your readme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Thank you 👍

@mertkahyaoglu mertkahyaoglu merged commit 02dccff into jekyll:master Feb 29, 2020
@monkeywithacupcake monkeywithacupcake deleted the opencollective branch April 13, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants