Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DataGUI into a bona fide component #546

Merged
merged 6 commits into from
Dec 15, 2019

Conversation

ashmaroli
Copy link
Member

In order to minimize repeated logic.
(However, there's still some logic repeated in the three components that consume DataGUI: DataFileNew, DataFileEdit and Configuration. But that seems to be necessary at the moment.)

Currently on master, DataGUI is just Metafields rendered with prop dataview: true and the inputs for editing data file path being additionally implemented for both DataFileNew and DataFileEdit.

Another internal change is to use input elements' ref value on save instead of setting the parent component's state and then reading from that value.

src/containers/views/Configuration.js Outdated Show resolved Hide resolved
src/containers/views/DataFileNew.js Outdated Show resolved Hide resolved
@ashmaroli ashmaroli merged commit 04a41da into jekyll:master Dec 15, 2019
@ashmaroli ashmaroli deleted the datagui-component branch December 15, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants