Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MetaButtons #549

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Refactor MetaButtons #549

merged 1 commit into from
Dec 2, 2019

Conversation

ashmaroli
Copy link
Member

Apart from simplifying the render() function, there are some other changes included in this proposal:

  • MetaButtons now use an internal state to determine the dropdown visibility — the class no longer uses props onDropdownFocus and onDropdownBlur to toggle showing-dropdown className on the parent wrapper — the class is attached to the dropdown trigger button itself.
  • The dropdown trigger toggles dropdown visibility — the dropdown gets hidden on both clicking the focused trigger and on the trigger losing focus.

mertkahyaoglu
mertkahyaoglu approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@mertkahyaoglu mertkahyaoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 👍

@ashmaroli ashmaroli merged commit 8d3debc into jekyll:master Dec 2, 2019
@ashmaroli ashmaroli deleted the refactor-metabuttons branch December 6, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertkahyaoglu mertkahyaoglu mertkahyaoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashmaroli @mertkahyaoglu