Reduce syntax-highlighting support in MDEditor #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundlesize stats
|
src/utils/highlighter.js
Outdated
| // hljs.registerLanguage('x86asm', require('highlight.js/lib/languages/x86asm')); | ||
| // hljs.registerLanguage('xl', require('highlight.js/lib/languages/xl')); | ||
| // hljs.registerLanguage('xquery', require('highlight.js/lib/languages/xquery')); | ||
| hljs.registerLanguage('zephir', require('highlight.js/lib/languages/zephir')); |
There was a problem hiding this comment.
I think we can store keys of languages we want to support in an array constant then register them in a loop.
It would be easier to see which languages are enabled that way.
There was a problem hiding this comment.
Technically, we can. But webpack won't evaluate the require code then and consequently include all languages in the bundle. To avoid that, we'll have to additionally configure webpack to remove the unneeded languages..
There was a problem hiding this comment.
Here are the couple of languages that I'm suggesting we don't need to support:
- zephir
- tcl
- vbscript-html
- qml
- q
- purebasic
- processing
- openscad
- moonscript
Bundlesize stats
|
mertkahyaoglu
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid bloating the production
bundle.jswith rarely used languages.