Use fetch wrapper for DELETE requests to dispatch #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/fetch.js
Outdated
| ) | ||
| .then(data => { | ||
| dispatch({ type: action_success.type }); | ||
| dispatch(action_success.update); |
There was a problem hiding this comment.
Why are there 2 dispatch here?
There was a problem hiding this comment.
@mertkahyaoglu Because the original logic sends two dispatches. For example:
export const deleteDraft = (directory, filename) => dispatch => {
return fetch(draftAPIUrl(directory, filename), {
method: 'DELETE',
credentials: 'same-origin',
})
.then(data => {
dispatch({ type: DELETE_DRAFT_SUCCESS });
dispatch(fetchDrafts(directory));
})
.catch(error =>
dispatch({
type: DELETE_DRAFT_FAILURE,
error,
})
);There was a problem hiding this comment.
Oh, is it because we are not updating state, just refetching all drafts again, right? That's bad actually 😄
There was a problem hiding this comment.
Hmm.. this double dispatch could also be the reason behind the race condition issues with the frontend layer and the Ruby backend.. not sure though.
There was a problem hiding this comment.
Fixed this double-dispatch in b11903b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a
fetchwrapper forDELETErequests, is left unused.Using the wrapper with slight modifications will bring consistency with
GETandPUTrequests that are sent via respective wrappers.