Allow searching without enter key press #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting snapshot failures when running tests on this branch locally.. can you please verify..? |
|
@ashmaroli I'm not getting any failures. This pr should effect snapshots though. What are your failures? |
|
@mertkahyaoglu Travis wasn't running all the tests.. You should now see the failures in the CI build logs.. |
mertkahyaoglu
force-pushed
the
search-improvement
branch
from
6094e01
to
d641727
Compare
mertkahyaoglu
force-pushed
the
search-improvement
branch
from
d641727
to
1b2976a
Compare
ashmaroli
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.