Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse tag markup once per instance #40

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

ashmaroli
Copy link
Member

This change ensures that if there is a single instance of {% avatar foo %} which may be rendered multiple times, the tag_markup or text parameter value isn't parsed by Liquid for each render.

@ashmaroli
Copy link
Member Author

Thanks for the approval, Ben. But since the tests are failing, I'll have to think of an alternative..

@ashmaroli ashmaroli force-pushed the reduce-liquid-template-instances branch from 7b60c75 to 097a100 Compare February 14, 2020 05:41
@ashmaroli ashmaroli force-pushed the reduce-liquid-template-instances branch from 097a100 to 917f827 Compare February 14, 2020 05:45
@ashmaroli ashmaroli requested a review from benbalter February 14, 2020 05:46
@benbalter
Copy link
Collaborator

@ashmaroli Thanks for all the great PRs this week. Any interest in maintaining this plugin, either in your own namespace or in Jekyll's?

@benbalter benbalter merged commit b0ad55c into jekyll:master Feb 14, 2020
@ashmaroli
Copy link
Member Author

Any interest in maintaining this plugin, either in your own namespace or in Jekyll's?

@benbalter I've pinged @mattr- regarding his opinion on transferring this plugin into the Jekyll Org.
Will get back to you once I get a response from him.

@ashmaroli ashmaroli deleted the reduce-liquid-template-instances branch February 14, 2020 16:10
@ashmaroli
Copy link
Member Author

@benbalter Both Parker and Matt are of the opinion that it would be best if Jekyll Org adopts this project rather than have it transferred into my namespace. So, they may approach you for the transfer in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants