Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Ruby for Travis #188

Merged
merged 1 commit into from
Aug 26, 2017
Merged

Bump Ruby for Travis #188

merged 1 commit into from
Aug 26, 2017

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Aug 25, 2017

Use latest Ruby like GitHub Pages

pathawks
pathawks reviewed Aug 26, 2017
View reviewed changes
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we might want to also test against the lowest version we support, just to make sure we're not using anything that is only supported in newer Ruby

@DirtyF
Test against Ruby 2.1 to 2.4
e884aed 
Use latest Ruby like GitHub Pages
@DirtyF
Copy link
Member Author

DirtyF commented Aug 26, 2017

@pathawks Right, updated to be coherent with other plugins.

@benbalter
Copy link
Contributor

@jekyllbot: merge.

@jekyllbot jekyllbot merged commit e9504b9 into jekyll:master Aug 26, 2017
jekyllbot added a commit that referenced this pull request Aug 26, 2017
@jekyllbot
Update history to reflect merge of #188 [ci skip]
519d73c
@DirtyF DirtyF deleted the patch-1 branch August 26, 2017 17:44
@jekyll jekyll locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DirtyF @benbalter @parkr @pathawks @jekyllbot