Excerpt only flag

[torrocus]

Create new flag excerpt_only, which allows to exclude post content from feed.

PR to issue: #277

BTW I don't like name excerpt_only, but don't have better idea. IMO this name should get true value for full content and false value for excerpt.

[parkr]

I dig this!

[ashmaroli]

@torrocus First of all, apologies for not reviewing this earlier.
While I don't have an issue with the idea, I'm on the fence regarding the implementation.

Since Parker has already approved this, I won't block this from being merged but would love it if you could clarify the following / make some changes:

• | default: false }} is unnecessary. The subsequent conditional is valid even if excerpt_only evaluates to nil.
• Why conditionally assign post_content and then immediately test post_content for a truthy? Why not render directly?

  {% unless excerpt_only %}
    <content type="html" xml:base="{{ post.url | absolute_url | xml_escape }}">
      {{ post.content | strip | xml_escape }}
    </content>
  {% endunless %}

[torrocus]

@parkr Thanks for dig.
@ashmaroli No problem, it's good to know someone is coming here.

Regarding your attention with | default: false }} you're right. I deleted the redundant default value. I wanted to show what the default value is. But later I included this information in the documentation and it should be enough.

Your second point is not that simple. Post does not always have content. The question is is this correct? View to file spec/fixtures/_posts/2015-02-12-strip-newlines.md
Personally, I would prefer render directly. But I do not know the whole context and did not want to interfere with existing functionalities.

[ashmaroli]

Post does not always have content

To my knowledge, the content attribute is never nil or anything other than a String. It can be just empty "" but in Ruby, that is considered a truthy as well.

Of course, having a test for this would make things clear and concrete.

[torrocus]

Right, I corrected it. Previously, one test failed. Now everything is OK, and I already had this code written in this way.

[torrocus]

Please squash all commits when you will merge.

[ashmaroli]

@parkr Since the diff changed significantly after you gave your approval, could you do a re-review?
Thanks.

[DirtyF]

Looks good to me.

[DirtyF]

@jekyllbot: merge +minor