Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): require Ruby >=2.4.0 #307

Merged
merged 5 commits into from
Jun 22, 2020
Merged

chore(deps): require Ruby >=2.4.0 #307

merged 5 commits into from
Jun 22, 2020

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Apr 13, 2020

Align with other core plugins that already require 2.4
Ruby 2.4 is now EOL.

@DirtyF DirtyF requested a review from ashmaroli April 13, 2020 12:15
@DirtyF DirtyF changed the title chore(deps): require Ruby >2.4 Align with other core plugins chore(deps): require Ruby >2.4 Apr 13, 2020
@ashmaroli
Copy link
Member

From what I recall, we have not started enforcing Ruby 2.4 in core plugin's gemspec if the library code doesn't use any Ruby 2.4+ specific syntax..

@DirtyF
Copy link
Member Author

DirtyF commented Apr 13, 2020

It's more about following Ruby release cycle, and require a maintained Ruby release.

You're right the current codebase style is OK even we were to target Ruby 2.7, but we didn't bother looking if we could use the latest Ruby additions.

@DirtyF
Copy link
Member Author

DirtyF commented Jun 20, 2020

@ashmaroli ashmaroli changed the title chore(deps): require Ruby >2.4 chore(deps): require Ruby >=2.4.0 Jun 21, 2020
@ashmaroli
Copy link
Member

I'm still of the opinion that this change is not necessary — there's no explicit need to use this plugin with Ruby 2.4 and above. But there's already an approval, so perhaps I'm not seeing the value..

@ashmaroli ashmaroli removed their request for review June 21, 2020 06:36
@DirtyF
Copy link
Member Author

DirtyF commented Jun 22, 2020

@jekyll: merge +minor

@jekyllbot jekyllbot merged commit be4577d into master Jun 22, 2020
@jekyllbot jekyllbot deleted the deps/Ruby2.4 branch June 22, 2020 13:31
jekyllbot added a commit that referenced this pull request Jun 22, 2020
@jekyll jekyll locked and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants