Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special character in file name #49

Open
jungbin-kim opened this issue Oct 4, 2017 · 2 comments
Open

special character in file name #49

jungbin-kim opened this issue Oct 4, 2017 · 2 comments

Comments

@jungbin-kim
Copy link

jungbin-kim commented Oct 4, 2017

In my case, gist file extension is ".scala".
So, I write below in my post.
{% gist jungbin-kim/acc54d54af4ff954105338534636526a Kakao-coding-test-#1.scala %}
However, it generates
https://gist.github.com/jungbin-kim/acc54d54af4ff954105338534636526a.js?file=Kakao-coding-test-
I think it miss special character like '#'

I expect like below
https://gist.github.com/jungbin-kim/acc54d54af4ff954105338534636526a?file=Kakao-coding-test-#1.scala

It might be involved at this line.

url = "https://gist.github.com/#{gist_id}.js"

Thank you

@jungbin-kim jungbin-kim changed the title Should file extension be ".js" ? special character in file name Oct 4, 2017
@jekyllbot jekyllbot added the stale label Dec 4, 2017
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@pathawks
Copy link
Member

pathawks commented Dec 4, 2017

It looks like GitHub just strips octothorps when creating ids. I guess we should strip them as well when creating the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants