Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip Octothorpe #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Strip Octothorpe #56

wants to merge 3 commits into from

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Dec 4, 2017 •
edited by pathawks
Loading

Fixes #49

@pathawks pathawks changed the title Add failing test Strip Octothorpe Dec 4, 2017
@pathawks pathawks force-pushed the pull/escape-octothorpe branch from 250a263 to 55bbb0d Compare December 4, 2017 21:01
@DirtyF DirtyF requested a review from a team February 2, 2018 20:19
@parkr
Copy link
Member

parkr commented Feb 2, 2018

Shouldn't we encode them?

@pathawks
Copy link
Member

pathawks commented Feb 2, 2018 •
edited
Loading

@parkr Nope. GitHub seems to just drop them.

Edit: Maybe. This doesn't seem to be working anymore the way I expected.

@pathawks
Copy link
Member

pathawks commented Feb 2, 2018

https://gist.github.com/pathawks/e6b4a0bbc8de8ffef6058a5a72dface2#file-my-file-txt

ashmaroli
ashmaroli reviewed Oct 26, 2018
View reviewed changes
lib/jekyll-gist/gist_tag.rb
@@ -11,13 +11,15 @@ module Jekyll
module Gist
class GistTag < Liquid::Tag
def render(context)
@special_characters = "#"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this an instance variable??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashmaroli ashmaroli ashmaroli left review comments

@DirtyF DirtyF DirtyF approved these changes

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jekyllbot @parkr @pathawks @mattr- @DirtyF @ashmaroli