-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jekyll 3.2 breaks jekyll-redirect-from if URL has colon #119
Comments
We also use colons in permalinks to preserve legacy MediaWiki URLs for https://github.com/biopython/biopython.github.io - e.g.:
We link to them using e.g. from
Note the colon in the relative link is escaped in the Markdown as We also use colons with
I've just filed jekyll/jekyll#5284 on this. |
@parkr it looks like you were involved in the original decision here.. can you weigh in a bit on the reasoning and possible workarounds? |
The reasoning: jekyll/jekyll-paginate#8 |
Does |
This is a workaround for a breaking change in latest Jekyll. See jekyll/jekyll-redirect-from#119
@benbalter yes, that seems to work and produces the correct filename with colon on disk. |
Percent encoding the colons in |
Suggested in jekyll/jekyll-redirect-from#119 as a workaround from the regression in Jekyll 3.2, see also: jekyll/jekyll#5284 This alone does not fix jekyll build in local testing.
Closing because this is a Jekyll core issue, rather than specific to this plugin. |
This is a workaround for a breaking change in latest Jekyll. See jekyll/jekyll-redirect-from#119
Add this to the frontmatter of a page:
Since Jekyll 3.2 this now throws the following error during build:
The culprit seems to be this PR in Jekyll jekyll/jekyll#5069 which throws this error now while it worked in the past.
I noticed this in one of my site which has a large collection of legacy links from MediaWiki which contain colons in the URL.
The text was updated successfully, but these errors were encountered: