Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce overall class size #132

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Reduce overall class size #132

merged 4 commits into from
Feb 24, 2022

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Feb 24, 2022

@ashmaroli
Copy link
Member

Thanks @ntkme
Lines 144-147 could be compacted as well.

@ntkme
Copy link
Contributor Author

ntkme commented Feb 24, 2022

@ashmaroli I think these are all I can find.

ashmaroli
ashmaroli approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ashmaroli
Copy link
Member

Thanks @ntkme
@jekyllbot: merge +dev

@ashmaroli
Copy link
Member

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 6b88b54 into jekyll:master Feb 24, 2022
jekyllbot added a commit that referenced this pull request Feb 24, 2022
@jekyllbot
Update history to reflect merge of #132 [ci skip]
771e663
@ntkme ntkme deleted the code-style branch February 24, 2022 17:21
@jekyll jekyll locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntkme @ashmaroli @jekyllbot