Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of sourcemap page #89

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Fix rendering of sourcemap page #89

merged 1 commit into from
Aug 4, 2019

Conversation

ashmaroli
Copy link
Member

Since page.content eventually gets rendered into page.output, setting the latter manually has no effect if the former is nil or empty.

@ashmaroli ashmaroli requested a review from DirtyF August 4, 2019 15:52
@DirtyF DirtyF added the fix label Aug 4, 2019
@DirtyF DirtyF added this to the v2.0 milestone Aug 4, 2019
@DirtyF
Copy link
Member

DirtyF commented Aug 4, 2019

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit bec9681 into jekyll:master Aug 4, 2019
@jekyllbot jekyllbot added the bug label Aug 4, 2019
jekyllbot added a commit that referenced this pull request Aug 4, 2019
@jekyllbot
Update history to reflect merge of #89 [ci skip]
cd9709a
@ashmaroli ashmaroli deleted the sourcemap-content-patch branch August 4, 2019 17:28
@jekyll jekyll locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmaroli @DirtyF @jekyllbot