Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scss#sass_dir_relative_to_site_source logic #99

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fix Scss#sass_dir_relative_to_site_source logic #99

merged 2 commits into from
Feb 5, 2020

Conversation

ashmaroli
Copy link
Member

Even though the method is named sass_dir_relative_to_site_source, the returned result is a path with site.source included.
Furthermore, since site.source is an absolute path, the returned path is absolute path as well.

This pull request proposes to strip away the site.source prefixed after sanitization of the sass_dir attribute.

Additionally resolves #98

@DirtyF DirtyF requested a review from a team February 5, 2020 12:11
@DirtyF DirtyF added the fix label Feb 5, 2020
@DirtyF

This comment has been minimized.

Sign in to view
@ashmaroli

This comment has been minimized.

Sign in to view
DirtyF
DirtyF approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding new tests 😻

@ashmaroli
Copy link
Member Author

We can't merge this right away since this changes the result of a public method. So let us wait for a comment from @parkr or @mattr-

mattr-
mattr- approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit fe52b1a into jekyll:master Feb 5, 2020
jekyllbot added a commit that referenced this pull request Feb 5, 2020
@jekyllbot
Update history to reflect merge of #99 [ci skip]
f9863cb
@ashmaroli ashmaroli deleted the sass-dir-relative-to-source branch February 5, 2020 13:26
@jekyll jekyll locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jekyll scss converter fails if parent folder name contains brackets
4 participants
@ashmaroli @DirtyF @mattr- @jekyllbot