Define path with __dir__ #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanvlviv
suggested changes
Aug 24, 2017
| @@ -15,11 +15,11 @@ class Drop | |||
| ENV["JEKYLL_LOG_LEVEL"] = "error" | |||
|
|
|||
| def dest_dir | |||
| File.expand_path("../tmp/dest", File.dirname(__FILE__)) | |||
| File.expand_path("tmp/dest", __dir__) | |||
There was a problem hiding this comment.
It should be File.expand_path("../tmp/dest", __dir__)
| end | ||
|
|
||
| def source_dir | ||
| File.expand_path("./fixtures", File.dirname(__FILE__)) | ||
| File.expand_path("./fixtures", __dir__) |
There was a problem hiding this comment.
would be nice to get rid of redundant .
|
Ooop. Sorry @DirtyF @bogdanvlviv got excited by learning something new and moved way too quickly. Glad to address the comments in a follow up PR. Sorry for the itchy finger. 100% my bad. |
|
@bogdanvlviv Thanks for the review. |
|
Since it was my mistake, I implemented both changes via cf90f90. Sorry about that. |
|
@benbalter, @DirtyF Nice job! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from jekyll/jekyll#6087 who itself took inspiration from rails/rails@5b8738c
/cc @bogdanvlviv