Fix: Consistently use self-closing tags #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@localheinz This breaks the tests. I'd better close all tags even if it's optional in HTML5. |
|
Ha, hang on - let me close the tags consistently and then see about making the tests pass! |
localheinz
force-pushed
the
fix/self-closing
branch
2 times, most recently
from
e661345 to
0b14907
Compare
1 task
localheinz
force-pushed
the
fix/self-closing
branch
from
0b14907 to
ce38618
Compare
benbalter
approved these changes
Nov 9, 2017
pathawks
approved these changes
Nov 9, 2017
|
Thanks @localheinz for this first contribution 👍 |
|
Thank you, @benbalter, @DirtyF, and @pathawks! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
💁♂️ Sometimes they are closed, sometimes they aren't - better to be consistent, I think.