Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize #author_hash in SeoTag::AuthorDrop #342

Merged
merged 3 commits into from
Nov 29, 2019
Merged

Memoize #author_hash in SeoTag::AuthorDrop #342

merged 3 commits into from
Nov 29, 2019

Conversation

ashmaroli
Copy link
Member

To avoid allocating a new Hash instance for every call to SeoTag::AuthorDrop#author_hash in every instance of SeoTag::AuthorDrop

@ashmaroli ashmaroli requested a review from a team July 17, 2019 16:08
@ashmaroli ashmaroli mentioned this pull request Jul 17, 2019
Closed
@DirtyF DirtyF added this to the Next minor version milestone Nov 13, 2019
@DirtyF
Copy link
Member

DirtyF commented Nov 29, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 895ab6c into jekyll:master Nov 29, 2019
jekyllbot added a commit that referenced this pull request Nov 29, 2019
@jekyllbot
Update history to reflect merge of #342 [ci skip]
68361c3
@jekyll jekyll locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
Next minor version
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @DirtyF @parkr @jekyllbot