Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locale specs that use the fallback locale #360

Merged
merged 5 commits into from
Jan 31, 2020
Merged

Fix locale specs that use the fallback locale #360

merged 5 commits into from
Jan 31, 2020

Conversation

ljcooke
Copy link
Contributor

@ljcooke ljcooke commented Sep 7, 2019

en_US should not be used to test site.lang and page.lang as this is also the fallback locale.

@ljcooke
Fix locale specs that use the fallback locale
713b1c6 
`en_US` should not be used to test `site.lang` and `page.lang` as this
is also the fallback locale.
DirtyF
DirtyF approved these changes Sep 7, 2019
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

US can be self-centered sometimes, thanks for the fix :)

@DirtyF DirtyF added this to the Next minor version milestone Nov 13, 2019
@ashmaroli
Copy link
Member

Thanks @ljcooke
@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 6f35c9c into jekyll:master Jan 31, 2020
jekyllbot added a commit that referenced this pull request Jan 31, 2020
@jekyllbot
Update history to reflect merge of #360 [ci skip]
0f24641
@ljcooke ljcooke deleted the fix-locale-spec branch January 31, 2020 10:54
@jekyll jekyll locked and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal tests
Projects
None yet
Milestone
Next minor version
Development

Successfully merging this pull request may close these issues.
4 participants
@ljcooke @ashmaroli @DirtyF @jekyllbot