Replace read-only empty hash with private constant #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third-party Repo Memory Profile Summary--- master https://github.com/jekyll/jekyll-seo-tag/runs/1226684766
+++ PR https://github.com/jekyll/jekyll-seo-tag/runs/1258882894
- Total allocated: 26.40 MB (214878 objects)
- Total retained: 19.52 kB (167 objects)
+ Total allocated: 25.18 MB (209612 objects)
+ Total retained: 19.39 kB (167 objects) |
mattr-
approved these changes
Oct 15, 2020
DirtyF
approved these changes
Oct 15, 2020
|
Thank you Matt and Frank :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid allocating multiple empty Hash objects for every instance of the Drop class.